[fix][ml] Make mlOwnershipChecker asynchronous so that it doesn't block/deadlock threads #21333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck/deadlock threads
lhotari
requested review from
Jason918,
rdhabalia,
Technoboy-,
codelipenghui,
Demogorgon314 and
liudezhi2098
|
@Demogorgon314 I wonder if this change would help also with the deadlock that you are fixing with #21332. |
2 tasks
Demogorgon314
approved these changes
Oct 10, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Show resolved
Hide resolved
lifepuzzlefun
approved these changes
Oct 10, 2023
merlimat
approved these changes
Oct 11, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Show resolved
Hide resolved
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Show resolved
Hide resolved
liudezhi2098
approved these changes
Oct 11, 2023
vinayakmalik95
pushed a commit
to tmdc-io/pulsar
that referenced
this pull request
Oct 12, 2023
…ck/deadlock threads (apache#21333)
|
@lhotari do you think we should back-port this to earlier branches? |
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…ck/deadlock threads (apache#21333) (cherry picked from commit eb9fa63) (cherry picked from commit 750547b)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…ck/deadlock threads (apache#21333) (cherry picked from commit eb9fa63) (cherry picked from commit 750547b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There's a synchronous method that is called from a thread which shouldn't be blocked. This happens in
ManagedCursorImpl.persistPositionMetaStoremethod when the blockingledger.mlOwnershipChecker.get()call is made.mlOwnershipCheckerwas introduced in #5604 and perhaps at that time, the method never blocked. This has changed and for example the flaky test #20157 has shown that this blocking happens in practice and causes deadlocks as reported in #21332.Modifications
Supplier<Boolean> mlOwnershipCheckerto an asynchronousSupplier<CompletableFuture<Boolean>> mlOwnershipCheckerManagedCursorImpl.persistPositionMetaStoreso that the callback for the top level method isn't called before the refreshing has occured.Documentation
docdoc-requireddoc-not-neededdoc-complete