[fix][broker] Fix incorrect unack count when using shared subscription on non-persistent topic #21592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on non-persistent topic
Technoboy-
reviewed
Nov 20, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
Outdated
Show resolved
Hide resolved
…n on non-persistent topic
Technoboy-
reviewed
Nov 21, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
Outdated
Show resolved
Hide resolved
…n on non-persistent topic
Technoboy-
approved these changes
Nov 21, 2023
liudezhi2098
approved these changes
Nov 27, 2023
poorbarcode
approved these changes
Nov 27, 2023
poorbarcode
reviewed
Nov 27, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
Outdated
Show resolved
Hide resolved
Technoboy-
requested changes
Nov 28, 2023
Technoboy-
reviewed
Nov 30, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
Outdated
Show resolved
Hide resolved
Technoboy-
reviewed
Nov 30, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Nov 30, 2023
|
@1Jack2 Thanks |
|
/pulsarbot rerun-failure-checks |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #21592 +/- ##
============================================
- Coverage 73.35% 73.31% -0.05%
- Complexity 32711 32726 +15
============================================
Files 1892 1892
Lines 140707 140709 +2
Branches 15483 15496 +13
============================================
- Hits 103211 103155 -56
- Misses 29394 29446 +52
- Partials 8102 8108 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
pushed a commit
that referenced
this pull request
Dec 3, 2023
…n on non-persistent topic (#21592) Fixes #21568 Motivation Fix incorrect unack count when using shared subscription on non-persistent topic Modifications In the case of a non-persistent topic, the consumer does not send an ack to the broker (see org.apache.pulsar.client.impl.NonPersistentAcknowledgmentGroupingTracker# addAcknowledgment) To work around this, we can update unackedMessages when the broker sends a message to the consumer successfully.
Technoboy-
pushed a commit
that referenced
this pull request
Dec 4, 2023
…n on non-persistent topic (#21592) Fixes #21568 Motivation Fix incorrect unack count when using shared subscription on non-persistent topic Modifications In the case of a non-persistent topic, the consumer does not send an ack to the broker (see org.apache.pulsar.client.impl.NonPersistentAcknowledgmentGroupingTracker# addAcknowledgment) To work around this, we can update unackedMessages when the broker sends a message to the consumer successfully.
Technoboy-
pushed a commit
that referenced
this pull request
Dec 4, 2023
…n on non-persistent topic (#21592) Fixes #21568 Motivation Fix incorrect unack count when using shared subscription on non-persistent topic Modifications In the case of a non-persistent topic, the consumer does not send an ack to the broker (see org.apache.pulsar.client.impl.NonPersistentAcknowledgmentGroupingTracker# addAcknowledgment) To work around this, we can update unackedMessages when the broker sends a message to the consumer successfully.
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
…n on non-persistent topic (apache#21592) Fixes apache#21568 Motivation Fix incorrect unack count when using shared subscription on non-persistent topic Modifications In the case of a non-persistent topic, the consumer does not send an ack to the broker (see org.apache.pulsar.client.impl.NonPersistentAcknowledgmentGroupingTracker# addAcknowledgment) To work around this, we can update unackedMessages when the broker sends a message to the consumer successfully.
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
…n on non-persistent topic (apache#21592) Fixes apache#21568 Motivation Fix incorrect unack count when using shared subscription on non-persistent topic Modifications In the case of a non-persistent topic, the consumer does not send an ack to the broker (see org.apache.pulsar.client.impl.NonPersistentAcknowledgmentGroupingTracker# addAcknowledgment) To work around this, we can update unackedMessages when the broker sends a message to the consumer successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21568
Motivation
Fix incorrect unack count when using shared subscription on non-persistent topic
Modifications
In the case of a non-persistent topic, the consumer does not send an ack to the broker (see
org.apache.pulsar.client.impl.NonPersistentAcknowledgmentGroupingTracker# addAcknowledgment)To work around this, we can update
unackedMessageswhen the broker sends a message to the consumer successfully.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository:
1Jack2#5