[fix][broker] Fix issue with GetMessageIdByTimestamp can't find match messageId from compacted ledger #21600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
requested review from
codelipenghui,
Technoboy-,
mattisonchao and
poorbarcode
coderzc
force-pushed
the
fix_find_timestamp_compaction
branch
from
b9b2db3
to
66cd16e
Compare
poorbarcode
reviewed
Jan 12, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
coderzc
force-pushed
the
fix_find_timestamp_compaction
branch
from
6477ce0
to
c4e6c58
Compare
codelipenghui
approved these changes
Jan 17, 2024
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Jan 18, 2024
poorbarcode
approved these changes
Jan 19, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Jan 22, 2024
… messageId from compacted ledger (#21600)
Technoboy-
pushed a commit
that referenced
this pull request
Jan 31, 2024
… messageId from compacted ledger (#21600)
coderzc
added a commit
that referenced
this pull request
Jan 31, 2024
… messageId from compacted ledger (#21600)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
… messageId from compacted ledger (apache#21600) (cherry picked from commit b5e4c36)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…nd match messageId from compacted ledger (apache#21600)" This reverts commit b5e4c36. (cherry picked from commit e53c19a)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
… messageId from compacted ledger (apache#21600) (cherry picked from commit 5bb2264)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
… messageId from compacted ledger (apache#21600) (cherry picked from commit b5e4c36)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…nd match messageId from compacted ledger (apache#21600)" This reverts commit b5e4c36. (cherry picked from commit e53c19a)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
… messageId from compacted ledger (apache#21600) (cherry picked from commit 5bb2264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, if topic compaction is enabled and the original ledger is trimmed, we won't be able to get the correct messageID by
publishTime, we should first try to find messageID from the compacted ledger. Since we introduced the findEntryByPublishTime method in PIP-286, we can easily implement it.Modifications
findFirstMatchEntryandfindFirstMatchIndexLoopmethods toCompactedTopicImplto cherry-pick this change into branches before 3.2.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: