Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fixed getting incorrect KeyValue schema version #21632

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

Technoboy-
Copy link
Contributor

Fixes #21587

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Copy link
Contributor

@liangyepianzhou liangyepianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a small comment.

@codecov-commenter
Copy link

Codecov Report

Merging #21632 (e58be2b) into master (e1d06b5) will increase coverage by 36.46%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21632       +/-   ##
=============================================
+ Coverage     36.83%   73.29%   +36.46%     
- Complexity      376    32716    +32340     
=============================================
  Files          1715     1892      +177     
  Lines        131097   140706     +9609     
  Branches      14318    15495     +1177     
=============================================
+ Hits          48288   103137    +54849     
+ Misses        76424    29462    -46962     
- Partials       6385     8107     +1722     
Flag Coverage Δ
inttests 24.09% <0.00%> (-0.15%) ⬇️
systests 24.64% <0.00%> (-0.28%) ⬇️
unittests 72.63% <100.00%> (+40.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../pulsar/broker/admin/impl/SchemasResourceBase.java 89.32% <100.00%> (+29.32%) ⬆️
...g/apache/pulsar/client/impl/HttpLookupService.java 81.25% <100.00%> (+26.37%) ⬆️
.../apache/pulsar/client/impl/schema/SchemaUtils.java 75.57% <ø> (+8.39%) ⬆️

... and 1455 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Pulsar Admin getVersionBySchema with KeyValue schema responds with -1
6 participants