-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fixed getting incorrect KeyValue schema version #21632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyepianzhou
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a small comment.
pulsar-client/src/main/java/org/apache/pulsar/client/impl/HttpLookupService.java
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #21632 +/- ##
=============================================
+ Coverage 36.83% 73.29% +36.46%
- Complexity 376 32716 +32340
=============================================
Files 1715 1892 +177
Lines 131097 140706 +9609
Branches 14318 15495 +1177
=============================================
+ Hits 48288 103137 +54849
+ Misses 76424 29462 -46962
- Partials 6385 8107 +1722
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
approved these changes
Nov 29, 2023
Technoboy-
added a commit
that referenced
this pull request
Dec 4, 2023
Technoboy-
added a commit
that referenced
this pull request
Dec 4, 2023
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
lhotari
added
release/2.10.7
release/2.11.5
and removed
release/2.10.6
release/2.11.4
labels
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.9.5
release/2.10.7
release/2.11.5
release/3.0.3
release/3.1.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21587
Documentation
doc
doc-required
doc-not-needed
doc-complete