Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Print recoverBucketSnapshot log if cursorProperties are empty #21651

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Dec 1, 2023

Motivation

In #21595, we lost the recoverBucketSnapshot log.

Modifications

Print recoverBucketSnapshot log if cursorProperties are empty.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 1, 2023
Copy link

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderzc coderzc closed this Dec 2, 2023
@coderzc coderzc reopened this Dec 2, 2023
@coderzc coderzc self-assigned this Dec 2, 2023
@coderzc coderzc added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker release/3.1.2 release/3.0.3 labels Dec 2, 2023
@coderzc coderzc added this to the 3.2.0 milestone Dec 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023

Codecov Report

Merging #21651 (e9952f0) into master (81a9a52) will increase coverage by 11.93%.
Report is 12 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21651       +/-   ##
=============================================
+ Coverage     24.71%   36.65%   +11.93%     
- Complexity      199    12226    +12027     
=============================================
  Files          1713     1716        +3     
  Lines        131084   131135       +51     
  Branches      14320    14324        +4     
=============================================
+ Hits          32403    48062    +15659     
+ Misses        93583    76694    -16889     
- Partials       5098     6379     +1281     
Flag Coverage Δ
inttests 24.17% <0.00%> (?)
systests 24.72% <0.00%> (+<0.01%) ⬆️
unittests 31.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ar/broker/authorization/AuthorizationProvider.java 3.70% <ø> (+1.85%) ⬆️
.../java/org/apache/pulsar/client/impl/ClientCnx.java 50.90% <ø> (+13.22%) ⬆️
...a/org/apache/pulsar/client/impl/Murmur3Hash32.java 80.00% <ø> (ø)
...r/delayed/bucket/BucketDelayedDeliveryTracker.java 0.00% <0.00%> (ø)

... and 561 files with indirect coverage changes

@Technoboy- Technoboy- merged commit aa3fcc9 into apache:master Dec 4, 2023
66 of 69 checks passed
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 20, 2023
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-3.0 cherry-picked/branch-3.1 doc-not-needed Your PR changes do not impact docs release/3.0.3 release/3.1.2 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants