Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][pip] PIP-322: Pulsar Rate Limiting Refactoring #21680

Merged
merged 21 commits into from
Dec 14, 2023

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Dec 6, 2023

Motivation

This contains PIP-322: Pulsar Rate Limiting Refactoring. Check the pip-322.md document for details.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari self-assigned this Dec 6, 2023
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Dec 6, 2023
pip/pip-322.md Outdated Show resolved Hide resolved
Copy link
Contributor

@asafm asafm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is good to Pulsar functionality, and more important - to Pulsar developers and even users trying to figure out the code.

I read the background reading blog linked (from the section you mentioned), and the text in the PIP. I can honestly say I understand only 30% of how the solution would really look like, so without prior background it's hard for me personally to give proper feedback. I usually stay clear of reading PRs implementing PIP as they harder to read and take more time than PIPs :) so I try to make sure I can understand what I can from the PIP.

I truly appreciate how this overall addition to Pulsar raises the bar for Pulsar 💪

pip/pip-322.md Outdated Show resolved Hide resolved
pip/pip-322.md Outdated Show resolved Hide resolved
pip/pip-322.md Outdated Show resolved Hide resolved
@lhotari lhotari requested review from tisonkun and mattisonchao and removed request for asafm December 14, 2023 10:57
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as PIP voted passed - https://lists.apache.org/thread/2s9hkmxovz1gop2031wk4v8skm270zh6

Thanks for driving this effort @lhotari!

@tisonkun tisonkun merged commit 58ae086 into apache:master Dec 14, 2023
19 checks passed
@Technoboy- Technoboy- added this to the 3.2.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants