[fix][offload] Don't cleanup data when offload met MetaStore exception #21686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xception --- ### Motivation apache#17915 changes the fix apache#17512 which lead the offload data is deleted when metadata store exception happened. Then the ledger can not be read. The logs shows ``` Failed to update offloaded metadata for the ledgerId 6197907, the offloaded data will not be cleaned up ``` But the ledger deleted. Then managed ledger failed to open it ``` Error opening ledger for reading at position 6197907:0 ```
hangc0276
approved these changes
Dec 7, 2023
mattisonchao
approved these changes
Dec 7, 2023
zymap
changed the title
|
/pulsarbot rerun-failure-checks |
codelipenghui
approved these changes
Dec 7, 2023
gaoran10
approved these changes
Dec 7, 2023
gaoran10
reviewed
Dec 7, 2023
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #21686 +/- ##
============================================
- Coverage 73.39% 73.34% -0.06%
+ Complexity 32763 32738 -25
============================================
Files 1893 1893
Lines 140753 140754 +1
Branches 15503 15503
============================================
- Hits 103306 103232 -74
- Misses 29346 29415 +69
- Partials 8101 8107 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaoran10
approved these changes
Dec 7, 2023
merlimat
approved these changes
Dec 7, 2023
merlimat
pushed a commit
that referenced
this pull request
Dec 7, 2023
merlimat
pushed a commit
that referenced
this pull request
Dec 7, 2023
15 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#17915 changes the fix #17512 which lead the offload data is deleted when metadata store exception happened. Then the ledger can not be read.
The logs shows
But the ledger deleted. Then managed ledger failed to open it
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: