Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][pip] PIP-323: Complete Backlog Quota Telemetry #21709

Merged
merged 4 commits into from Dec 20, 2023

Conversation

asafm
Copy link
Contributor

@asafm asafm commented Dec 11, 2023

Motivation

PIP-323 is introduced to fill the gap of backlog quota telemetry. It allows the user to know when a time-based backlog quota is about to exceed, and how many times it exceeded. It also adds backlog quota check duration metric allowing the user to configure the interval for that check based on data. Once this is implemented, the user can finally create and alert to know when a certain topic is about to exceed its defined backlog quota limit, alert on it, and using topic stats Admin API to grab the subscription name causing it.

Modifications

Adding PIP-323

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added type/PIP doc-not-needed Your PR changes do not impact docs labels Dec 11, 2023
@asafm
Copy link
Contributor Author

asafm commented Dec 11, 2023

This PIP is based on #19601

Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a nice proposal with a clear background, and easy to read.
Just left a few minor comments

pip/pip-323.md Outdated Show resolved Hide resolved
pip/pip-323.md Outdated Show resolved Hide resolved
Copy link

@yuweisung yuweisung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.
Thanks for this pip.

@Technoboy-
Copy link
Contributor

File name should be pip-323

@asafm
Copy link
Contributor Author

asafm commented Dec 13, 2023

File name should be pip-323

@Technoboy- What am I missing?
image

@Technoboy-
Copy link
Contributor

File name should be pip-323

@Technoboy- What am I missing? image

Ah, sorry.

@Technoboy- Technoboy- added this to the 3.2.0 milestone Dec 14, 2023
@Technoboy-
Copy link
Contributor

Need to update the vote thread

@asafm
Copy link
Contributor Author

asafm commented Dec 20, 2023

@Technoboy- Can you please merge this? The PIP vote approved it.

@dao-jun dao-jun merged commit 8548de1 into apache:master Dec 20, 2023
19 checks passed
@asafm asafm deleted the pip-backlog-quota-telemetry branch December 20, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs type/PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants