Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Improve NamespaceUnloadStrategy error message #21880

Merged
merged 4 commits into from
Jan 11, 2024
Merged

[improve][broker] Improve NamespaceUnloadStrategy error message #21880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86c14c8
Fix load balancer shedding strategy in ProxyWithExtensibleLoadManager…
dragosvictor Jan 10, 2024
e8694f7
Fix class load error message in UnloadScheduler
dragosvictor Jan 10, 2024
77503e8
Use canonical name for consistency
dragosvictor Jan 10, 2024
69f619e
Fix option name in log message
dragosvictor Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .../main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/UnloadScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,8 @@ private static NamespaceUnloadStrategy createNamespaceUnloadStrategy(PulsarServi
Thread.currentThread().getContextClassLoader());
log.info("Created namespace unload strategy:{}", unloadStrategy.getClass().getCanonicalName());
} catch (Exception e) {
log.error("Error when trying to create namespace unload strategy: {}",
conf.getLoadBalancerLoadPlacementStrategy(), e);
log.error("create namespace unload strategy failed. using TransferShedder instead.");
log.error("Error when trying to create namespace unload strategy: {}. Using {} instead.",
conf.getLoadBalancerLoadSheddingStrategy(), TransferShedder.class.getCanonicalName(), e);
unloadStrategy = new TransferShedder();
}
unloadStrategy.initialize(pulsar);
Expand Down
2 changes: 2 additions & 0 deletions ...roxy/src/test/java/org/apache/pulsar/proxy/server/ProxyWithExtensibleLoadManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import org.apache.pulsar.broker.ServiceConfiguration;
import org.apache.pulsar.broker.authentication.AuthenticationService;
import org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl;
import org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder;
import org.apache.pulsar.client.admin.PulsarAdminException;
import org.apache.pulsar.client.api.PulsarClient;
import org.apache.pulsar.client.api.PulsarClientException;
Expand Down Expand Up @@ -97,6 +98,7 @@ private ServiceConfiguration configureExtensibleLoadManager(ServiceConfiguration
config.setLoadBalancerInFlightServiceUnitStateWaitingTimeInMillis(5 * 1000);
config.setLoadBalancerServiceUnitStateMonitorIntervalInSeconds(1);
config.setLoadManagerClassName(ExtensibleLoadManagerImpl.class.getName());
config.setLoadBalancerLoadSheddingStrategy(TransferShedder.class.getName());
config.setLoadBalancerSheddingEnabled(false);
return config;
}
Expand Down
Loading