Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [bk] Upgrade BookKeeper dependency to 4.16.4 #21983

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

hangc0276
Copy link
Contributor

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

BookKeeper 4.16.4 has been released and upgrade the BookKeeper dependency to 4.16.4

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@hangc0276 hangc0276 self-assigned this Jan 29, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 29, 2024
@hangc0276 hangc0276 added release/3.0.3 release/3.1.3 release/3.2.1 and removed doc-not-needed Your PR changes do not impact docs labels Jan 29, 2024
@hangc0276 hangc0276 added this to the 3.3.0 milestone Jan 29, 2024
@hangc0276 hangc0276 added dependencies Pull requests that update a dependency file ready-to-test labels Jan 29, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a18043) 36.55% compared to head (6e4145c) 73.56%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21983       +/-   ##
=============================================
+ Coverage     36.55%   73.56%   +37.01%     
- Complexity    12406    32452    +20046     
=============================================
  Files          1727     1863      +136     
  Lines        131880   138772     +6892     
  Branches      14419    15203      +784     
=============================================
+ Hits          48208   102094    +53886     
+ Misses        77249    28788    -48461     
- Partials       6423     7890     +1467     
Flag Coverage Δ
inttests 24.09% <ø> (+<0.01%) ⬆️
systests 23.62% <ø> (-0.18%) ⬇️
unittests 72.86% <ø> (+40.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1437 files with indirect coverage changes

Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit ae272a5 into apache:master Jan 29, 2024
53 of 56 checks passed
lhotari pushed a commit that referenced this pull request Jan 29, 2024
lhotari pushed a commit that referenced this pull request Jan 29, 2024
lhotari pushed a commit that referenced this pull request Jan 29, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 1, 2024
(cherry picked from commit ae272a5)
(cherry picked from commit afabcc2)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 6, 2024
(cherry picked from commit ae272a5)
(cherry picked from commit afabcc2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants