[fix][broker]Support setting autoSkipNonRecoverableData dynamically in expiryMon…
#21991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Can we add a test for this case? |
done, PTAL |
Technoboy-
approved these changes
Feb 6, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #21991 +/- ##
============================================
- Coverage 73.65% 73.60% -0.06%
- Complexity 32471 32481 +10
============================================
Files 1863 1863
Lines 138772 138816 +44
Branches 15203 15216 +13
============================================
- Hits 102213 102171 -42
- Misses 28665 28743 +78
- Partials 7894 7902 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
approved these changes
Feb 18, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Feb 22, 2024
… in expiryMon… (#21991) Co-authored-by: atomchchen <atomchchen@tencent.com>
Technoboy-
added
release/3.2.1
cherry-picked/branch-3.0
cherry-picked/branch-3.2
and removed
release/3.1.2
labels
Technoboy-
pushed a commit
that referenced
this pull request
Feb 26, 2024
… in expiryMon… (#21991) Co-authored-by: atomchchen <atomchchen@tencent.com>
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
Mar 4, 2024
… in expiryMon… (apache#21991) Co-authored-by: atomchchen <atomchchen@tencent.com> (cherry picked from commit 220a3d6)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 4, 2024
… in expiryMon… (apache#21991) Co-authored-by: atomchchen <atomchchen@tencent.com> (cherry picked from commit 220a3d6) (cherry picked from commit 09cb541)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
… in expiryMon… (apache#21991) Co-authored-by: atomchchen <atomchchen@tencent.com> (cherry picked from commit 220a3d6) (cherry picked from commit 09cb541)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support setting
autoSkipNonRecoverableDatadynamically inPersistentMessageExpiryMonitorDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: