Issue #2204: support v2 namespace in cpp client #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
sijie
approved these changes
Jul 20, 2018
sijie
pushed a commit
that referenced
this pull request
Aug 27, 2018
### Motivation In pulsar-client-cpp, TopicName support V2 type, and contains method isV2Topic(), but NamespaceName not support it. We need to add support for NamespaceName to make it align with java client. ### Modifications - add v2 support in NamespaceName - add test case for it ### Result old behaviour not changed.
|
merged as c34ad4 to branch-2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In pulsar-client-cpp, TopicName support V2 type, and contains method isV2Topic(), but NamespaceName not support it.
We need to add support for NamespaceName to make it align with java client.
Modifications
Result
old behaviour not changed.