[improve][fn] Add missing "exception" argument to some log.error
#22140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangpengcheng
changed the title
log.error
Technoboy-
approved these changes
Feb 28, 2024
dao-jun
approved these changes
Feb 28, 2024
|
@jiangpengcheng We have a conflict in branch-3.0. Can you hep to raise a cherry-pick PR to branch-3.0? |
|
@jiangpengcheng Could you help to also raise a cherry-pick PR to branch-3.1? |
jiangpengcheng
added a commit
to jiangpengcheng/pulsar
that referenced
this pull request
Mar 7, 2024
heesung-sn
pushed a commit
that referenced
this pull request
Mar 7, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
…og.error` (apache#22140) (apache#22213) (cherry picked from commit dc035f5)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…og.error` (apache#22140) (apache#22213) (cherry picked from commit dc035f5)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…og.error` (apache#22140) (apache#22213) (cherry picked from commit dc035f5)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…og.error` (apache#22140) (apache#22213) (cherry picked from commit dc035f5)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…og.error` (apache#22140) (apache#22213) (cherry picked from commit dc035f5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
While debugging an error for function trigger, the logs only print:
Function in trigger function is not ready @ /public/default/test, which is useless without the error stack trace, it's better to add it, I also found otherlog.errormissed the "exception" argument while most oflog.errorhas it.Modifications
Add exception as the last argument to calling of
log.errorwhich missed itVerifying this change
Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: