Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][cli] Fix the bug when set-retention specified size with -T #22150

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Technoboy-
Copy link
Contributor

Fixes #22138

Motivation

When specified with -s with -xT, it will overflow when convert long to int.
image
image

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- self-assigned this Feb 28, 2024
@Technoboy- Technoboy- added this to the 3.3.0 milestone Feb 28, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 28, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good work @Technoboy-

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.54%. Comparing base (bbc6224) to head (c3fd693).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22150      +/-   ##
============================================
- Coverage     73.57%   73.54%   -0.04%     
+ Complexity    32624    32116     -508     
============================================
  Files          1877     1877              
  Lines        139502   139546      +44     
  Branches      15299    15312      +13     
============================================
- Hits         102638   102627      -11     
- Misses        28908    28954      +46     
- Partials       7956     7965       +9     
Flag Coverage Δ
inttests 24.65% <0.00%> (+0.07%) ⬆️
systests 24.24% <0.00%> (-0.08%) ⬇️
unittests 72.79% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ava/org/apache/pulsar/admin/cli/CmdNamespaces.java 78.73% <50.00%> (ø)

... and 55 files with indirect coverage changes

@lhotari lhotari merged commit f33a3f4 into apache:master Feb 28, 2024
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] pulsar-admin set-retention reports an invalid retention policy when size != -1
6 participants