[improve][broker] Consistently add fine-grain authorization to REST API #22202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fine-grained authorization(FGA) to topic management endpoints. So that it can be controlled at a more fine-grain level. The changed endpoints are as follows: **Topic Policy** - offload policeis - max unacked message on consumer - max unacked message on subscription - duplication snapshot - inactive topic - delayed delivery - backlog - replication - message ttl - deduplication - dispatch pause - persistence - max subscriptions - max producers - max consumers - message size - compaction threshold - replication rate - dispatch rate - publish rate - subscribe rate - subscriptino types - schema capatibility - auto subscription creation **Topic Operation** - examine message - get backlog
mattisonchao
changed the title
lhotari
reviewed
Mar 6, 2024
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/PolicyName.java
Outdated
Show resolved
Hide resolved
|
Good work @mattisonchao ! |
lhotari
approved these changes
Mar 6, 2024
Technoboy-
approved these changes
Mar 6, 2024
gaoran10
reviewed
Mar 6, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
Show resolved
Hide resolved
liangyepianzhou
approved these changes
Mar 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22202 +/- ##
============================================
+ Coverage 73.57% 73.60% +0.03%
- Complexity 32624 32722 +98
============================================
Files 1877 1878 +1
Lines 139502 139708 +206
Branches 15299 15328 +29
============================================
+ Hits 102638 102834 +196
+ Misses 28908 28882 -26
- Partials 7956 7992 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaoran10
approved these changes
Mar 6, 2024
|
@mattisonchao could you help to cherry-pick this PR to 3.0 branch? I see conflicts. |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 3, 2024
…PI (apache#22202) (cherry picked from commit 68c1092) (cherry picked from commit dcaf508)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 4, 2024
…PI (apache#22202) (cherry picked from commit 68c1092) (cherry picked from commit dcaf508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add fine-grain authorization to topic management endpoints so that it can be controlled at a more fine-grain level.
Modifications
The changed endpoints are as follows:
Topic Policy
Topic Operation
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete