Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [broker] Support create RawReader based on configuration #22280

Conversation

hangc0276
Copy link
Contributor

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

When I use one Pulsar client to create multiple RawReaders to consume multiple topics, I need fine-grained control on the RawReader, such as changing the receiver queue size and enabling the AutoScaledReceiverQueueSize to control the Pulsar client memory usage to avoid direct memory OOM.

However, the current RawReader configuration is hard-coded and can't change anything.

consumerConfiguration = new ConsumerConfigurationData<>();
consumerConfiguration.getTopicNames().add(topic);
consumerConfiguration.setSubscriptionName(subscription);
consumerConfiguration.setSubscriptionType(SubscriptionType.Exclusive);
consumerConfiguration.setReceiverQueueSize(DEFAULT_RECEIVER_QUEUE_SIZE);
consumerConfiguration.setReadCompacted(true);
consumerConfiguration.setSubscriptionInitialPosition(SubscriptionInitialPosition.Earliest);
consumerConfiguration.setAckReceiptEnabled(true);

We can provide more flexible control over RawReader creation.

Modifications

Provide a more flexible API to allow user to pass ConsumerConfigurationData to create RawReader.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@hangc0276 hangc0276 changed the title Support create RawReader based on configuration [improve] [broker] Support create RawReader based on configuration Mar 15, 2024
@hangc0276 hangc0276 self-assigned this Mar 15, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 15, 2024
@hangc0276 hangc0276 added release/3.2.2 category/functionality Some functions are not working such as get errors and removed doc-not-needed Your PR changes do not impact docs labels Mar 15, 2024
@hangc0276 hangc0276 added this to the 3.3.0 milestone Mar 15, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 15, 2024
Copy link
Contributor

@poorbarcode poorbarcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a test to confirm the config has been used.

@hangc0276
Copy link
Contributor Author

We can add a test to confirm the config has been used.

@poorbarcode Added a unit test.

Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Technoboy- Technoboy- merged commit 34f8e0e into apache:master Mar 18, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/functionality Some functions are not working such as get errors cherry-picked/branch-3.2 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants