Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][fn] Pass FunctionDetails to Go instance #22350

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

jiangpengcheng
Copy link
Contributor

@jiangpengcheng jiangpengcheng commented Mar 26, 2024

Fixes #22349

Main Issue: #xyz

PIP: #xyz

Motivation

The Go instance doesn't get the full FunctionDetails, which makes it missing many features like Java and Python

Modifications

Pass the FunctionDetails string directly to Go and unmarshal it to the FunctionDetails struct

Verifying this change

  • Make sure that the change passes the CI checks.

  • This change is already covered by existing tests, such as (please describe tests).

    • org.apache.pulsar.tests.integration.functions.go.PulsarFunctionsGoProcessTest
    • org.apache.pulsar.tests.integration.functions.go.PulsarFunctionsGoThreadTest
    • org.apache.pulsar.functions.runtime.kubernetes.KubernetesRuntimeTest
  • This change added tests and can be verified as follows:

    • Added unit test for config with valid, invalid, and empty "FunctionDetails"

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: jiangpengcheng#31

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 26, 2024
@Technoboy- Technoboy- requested a review from shibd March 26, 2024 08:06
@shibd shibd closed this Mar 27, 2024
@shibd shibd reopened this Mar 27, 2024
@shibd shibd added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/function labels Mar 27, 2024
@Technoboy- Technoboy- merged commit 7315aeb into apache:master Mar 29, 2024
52 checks passed
@Technoboy- Technoboy- added this to the 3.3.0 milestone Mar 29, 2024
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function doc-not-needed Your PR changes do not impact docs ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang instance of functions missing many fields of the FunctionDetails
3 participants