Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Support OIDC providers with JWK without alg field set in keys #22421

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Apr 4, 2024

Fixes #22419

Motivation

See #22419. "alg" field is optional in JWK spec.

Modifications

  • allow missing "alg" field
  • add test case

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.3.0 milestone Apr 4, 2024
@lhotari lhotari self-assigned this Apr 4, 2024
@lhotari lhotari requested a review from tuteng April 4, 2024 05:02
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 4, 2024
Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.73%. Comparing base (bbc6224) to head (a403740).
Report is 115 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22421      +/-   ##
============================================
+ Coverage     73.57%   73.73%   +0.16%     
+ Complexity    32624    32402     -222     
============================================
  Files          1877     1885       +8     
  Lines        139502   139881     +379     
  Branches      15299    15321      +22     
============================================
+ Hits         102638   103146     +508     
+ Misses        28908    28759     -149     
- Partials       7956     7976      +20     
Flag Coverage Δ
inttests 26.95% <0.00%> (+2.37%) ⬆️
systests 24.67% <0.00%> (+0.35%) ⬆️
unittests 73.00% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...hentication/oidc/AuthenticationProviderOpenID.java 75.69% <0.00%> (-1.11%) ⬇️

... and 178 files with indirect coverage changes

@lhotari lhotari merged commit a1970ae into apache:master Apr 4, 2024
52 checks passed
lhotari added a commit that referenced this pull request Apr 4, 2024
lhotari added a commit that referenced this pull request Apr 4, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 15, 2024
…n keys (apache#22421)

(cherry picked from commit a1970ae)
(cherry picked from commit 4a79a26)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
…n keys (apache#22421)

(cherry picked from commit a1970ae)
(cherry picked from commit 4a79a26)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
…n keys (apache#22421)

(cherry picked from commit a1970ae)
(cherry picked from commit 4a79a26)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 19, 2024
…n keys (apache#22421)

(cherry picked from commit a1970ae)
(cherry picked from commit 4a79a26)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
…n keys (apache#22421)

(cherry picked from commit a1970ae)
(cherry picked from commit 4a79a26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] OIDC - Optional alg field being required in Pulsar causes OIDC authentication to fail
3 participants