Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][broker] remove useless code comment #22459

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Apr 8, 2024

Motivation

These notes are introduced by #9490, and the related code has been removed. We have better remove these remaining notes in case of confusion.

Modifications

Remove notes.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#46

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 8, 2024
@thetumbled
Copy link
Member Author

PTAL, thanks. @congbobo184 @liangyepianzhou

@lhotari lhotari changed the title [cleanup] [broker] remove useless note. [cleanup][broker] remove useless code comment Apr 8, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit b162d46 into apache:master Apr 9, 2024
55 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants