Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Add topic name to emitted error messages. #22506

Merged
merged 3 commits into from
Apr 16, 2024
Merged

[improve][broker] Add topic name to emitted error messages. #22506

merged 3 commits into from
Apr 16, 2024

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Apr 15, 2024

Fixes #22505

Motivation

Add topic name to emitted error messages.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@dao-jun dao-jun requested a review from lhotari April 15, 2024 09:12
@dao-jun dao-jun self-assigned this Apr 15, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 15, 2024
@dao-jun dao-jun added this to the 3.3.0 milestone Apr 15, 2024
@Technoboy- Technoboy- changed the title [fix] Add topic name to emitted error messages. [improve][broker] Add topic name to emitted error messages. Apr 15, 2024
lhotari
lhotari approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dao-jun dao-jun merged commit d5b36da into apache:master Apr 16, 2024
48 of 50 checks passed
@dao-jun dao-jun deleted the dev/add_topic_name_to_exception branch April 16, 2024 19:14
lhotari pushed a commit that referenced this pull request Apr 22, 2024
@dao-jun @lhotari
[improve][broker] Add topic name to emitted error messages. (#22506)
1d202f9 
(cherry picked from commit d5b36da)
lhotari pushed a commit that referenced this pull request Apr 22, 2024
@dao-jun @lhotari
[improve][broker] Add topic name to emitted error messages. (#22506)
5d47465 
(cherry picked from commit d5b36da)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
@dao-jun @mukesh-ctds
[improve][broker] Add topic name to emitted error messages. (apache#2…
6839bb2 
…2506)

(cherry picked from commit d5b36da)
(cherry picked from commit 1d202f9)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
@dao-jun @srinath-ctds
[improve][broker] Add topic name to emitted error messages. (apache#2…
00c2fbb 
…2506)

(cherry picked from commit d5b36da)
(cherry picked from commit 1d202f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari approved these changes

Assignees

@dao-jun dao-jun

Labels
cherry-picked/branch-3.0 cherry-picked/branch-3.2 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.5 release/3.1.4 release/3.2.3
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Add topic name to emitted error messages
2 participants
@dao-jun @lhotari