-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][cli]Support for pulsar-shell persistent modes #22515
Conversation
private static boolean isExitModeCommand(String line) { | ||
return line.equalsIgnoreCase("exitmode"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there shouldn't be a separate exitmode
command. Simple exit
or pressing CTRL-D should do that.
} | ||
|
||
private static boolean isChangeModeCommand(String line) { | ||
return line.equalsIgnoreCase("admin") || line.equalsIgnoreCase("client") || line.equalsIgnoreCase("config"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like duplication. I'd assume that the ShellMode enum would have a status lookup method instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for example https://www.baeldung.com/java-enum-values contains some advice how this could be handled.
@sandeep-mst Thanks for the contribution. Please target the |
Closing in favour of #22522 |
Fixes 21194 of apache/pulsar
Motivation
Pulsar shell doesn't support persistent mode for admin, client, config. If we need to run a lot of admin commands for example, we would need to prefix admin each time. This will provide an alternative approach.
Modifications
Modified so that
admin
,client
,config
commands individually will launch their own mode and prompt message also gets updated.exitmode
command will exit from the mode to the default mode.In the admin mode, we can run command
topics
instead ofadmin topics
.Verifying this change
(Please pick either of the following options)
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository:
cognitree#5