Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][offload] Increase file upload limit from 2048MiB to 4096MiB for GCP/GCS offloading #22554

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Apr 22, 2024

Fixes #15159

Motivation

Modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

… GCP/GCS offloading

- JClouds 2.6.0 has a limit of 32 blocks
- Increase default gcsManagedLedgerOffloadMaxBlockSizeInBytes from 64MiB to 128MiB to increase the limit
  from 2048MiB to 4096MiB
- Use "MiB" unit for 1024^2 bytes ("MB" is 10^6 bytes)
  - https://en.wikipedia.org/wiki/Byte#Multiple-byte_units
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!

I was about to reopen the issue because I was still able to reproduce the problem

@lhotari lhotari merged commit e81f370 into apache:master Apr 22, 2024
50 of 52 checks passed
lhotari added a commit that referenced this pull request Apr 22, 2024
lhotari added a commit that referenced this pull request Apr 22, 2024
lhotari added a commit that referenced this pull request Apr 22, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
… GCP/GCS offloading (apache#22554)

(cherry picked from commit e81f370)
(cherry picked from commit 5c09c20)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
… GCP/GCS offloading (apache#22554)

(cherry picked from commit e81f370)
(cherry picked from commit 5c09c20)
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offloading large ledgers (>2GB) fail with Google Cloud Storage
2 participants