[fix][io] CompressionEnabled didn't work on elasticsearch sink #22565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
added
type/bug
shibd
requested review from
lhotari,
hangc0276,
Technoboy-,
RobertIndie,
nicoloboschi,
poorbarcode and
coderzc
Technoboy-
approved these changes
Apr 24, 2024
shibd
added a commit
that referenced
this pull request
Apr 24, 2024
(cherry picked from commit a3cd1f8)
shibd
added a commit
that referenced
this pull request
Apr 24, 2024
(cherry picked from commit a3cd1f8)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 13, 2024
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We observed that the traffic passing through the
es-sinkwas amplified by 8 times, and it didn't work even if enablecompression.The root cause is here configure
responsecompression notrequest. Refer to this discuss.pulsar/pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/client/elastic/ElasticSearchJavaRestClient.java
Line 83 in 45fdbac
Modifications
Verifying this change
Before this change:
After this change:
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: