Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix permission for subscription. #22579

Closed
wants to merge 1 commit into from

Conversation

thetumbled
Copy link
Contributor

@thetumbled thetumbled commented Apr 25, 2024

Motivation

Modifications

Do not allow to subscribe if the role do not have the permission really.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#49

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 25, 2024
@thetumbled
Copy link
Contributor Author

@Technoboy-
Copy link
Contributor

Could you help add a test for this ?

@Technoboy- Technoboy- closed this Apr 25, 2024
@Technoboy- Technoboy- changed the title [fix] [broker] fix permission hole for subscription. [fix] [broker] Fix permission for subscription. Apr 25, 2024
@Technoboy- Technoboy- changed the title [fix] [broker] Fix permission for subscription. [fix][broker] Fix permission for subscription. Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/authn area/broker doc-not-needed Your PR changes do not impact docs type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants