Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] [test] remove useless TestAuthorizationProvider2 #22595

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[cleanup] [test] remove useless TestAuthorizationProvider2 #22595

merged 1 commit into from
Apr 26, 2024

Conversation

thetumbled
Copy link
Contributor

@thetumbled thetumbled commented Apr 26, 2024 •
edited

Motivation

TestAuthorizationProvider2 is useless, no need to retain.

Modifications

Remove it.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 26, 2024
@thetumbled
Copy link
Contributor Author

PTAL, thanks. @Technoboy- @lhotari

lhotari
lhotari approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetumbled
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@lhotari lhotari merged commit d19860c into apache:master Apr 26, 2024
50 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari approved these changes

Assignees
No one assigned
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thetumbled @lhotari