Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [pip] PIP-349: Add additionalSystemCursorNames ignore list for TTL check #22651

Merged
merged 4 commits into from
May 9, 2024

Conversation

hangc0276
Copy link
Contributor

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the PIP label May 4, 2024
@hangc0276 hangc0276 self-assigned this May 4, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 4, 2024
@hangc0276 hangc0276 added type/PIP and removed doc-not-needed Your PR changes do not impact docs labels May 4, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 4, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangc0276 hangc0276 changed the title [improve] [pip] PIP-349: Add systemCursorNames ignore list for ttl check [improve] [pip] PIP-349: Add additionalSystemCursorNames ignore list for TTL check May 6, 2024
Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to clearly state that we're adding a new item for the service configuration.

pip/pip-349.md Outdated Show resolved Hide resolved
pip/pip-349.md Outdated Show resolved Hide resolved
@Technoboy- Technoboy- added this to the 3.4.0 milestone May 9, 2024
@hangc0276 hangc0276 merged commit 0fd223d into apache:master May 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs PIP type/PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants