Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Remove unused method CompactionRecord.reset #22670

Merged

Conversation

dragosvictor
Copy link
Contributor

Motivation

Remove unused methods CompactionRecord::reset and caller CompactionRecordMXBeanImpl::reset. These methods are not used anywhere outside of the tests. Mistakenly using them can cause the topic compaction metrics to be invalidated.

Modifications

Trivial cleanup.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: dragosvictor#21

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.73%. Comparing base (bbc6224) to head (479bb70).
Report is 240 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22670      +/-   ##
============================================
- Coverage     73.57%   72.73%   -0.85%     
+ Complexity    32624    32550      -74     
============================================
  Files          1877     1887      +10     
  Lines        139502   141053    +1551     
  Branches      15299    15481     +182     
============================================
- Hits         102638   102590      -48     
- Misses        28908    30584    +1676     
+ Partials       7956     7879      -77     
Flag Coverage Δ
inttests 27.43% <ø> (+2.85%) ⬆️
systests 24.70% <ø> (+0.38%) ⬆️
unittests 71.49% <ø> (-1.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...org/apache/pulsar/compaction/CompactionRecord.java 100.00% <ø> (ø)
.../apache/pulsar/compaction/CompactorMXBeanImpl.java 94.44% <ø> (-0.56%) ⬇️

... and 353 files with indirect coverage changes

@merlimat merlimat merged commit ad75e3f into apache:master May 8, 2024
54 of 55 checks passed
@dragosvictor dragosvictor deleted the dmisca-compaction-record-cleanup branch May 14, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants