[fix][offload] Fix OOM in tiered storage, caused by unbounded offsets cache #22679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
May 8, 2024
hangc0276
reviewed
May 8, 2024
...age/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/OffsetsCache.java
Outdated
Show resolved
Hide resolved
...age/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/OffsetsCache.java
Show resolved
Hide resolved
...age/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/OffsetsCache.java
Show resolved
Hide resolved
...age/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/OffsetsCache.java
Outdated
Show resolved
Hide resolved
dao-jun
approved these changes
May 9, 2024
|
Follow up to fix a small issue: #22683 |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 13, 2024
… cache (apache#22679) Co-authored-by: Jiwe Guo <technoboy@apache.org> (cherry picked from commit 566330c) (cherry picked from commit f091bcb)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
… cache (apache#22679) Co-authored-by: Jiwe Guo <technoboy@apache.org> (cherry picked from commit 566330c) (cherry picked from commit f091bcb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #16417 a cache was added for caching offsets. The problem with this implementation is that in some cases, the
memory consumption can go very high and cause OOM.
Modifications
pulsar.jclouds.readhandleimpl.offsetsscache.max.sizeto adjust this, however there shouldn't be a need to tune it.Documentation
docdoc-requireddoc-not-neededdoc-complete