[improve] [log] Print source client addr when enabled haProxyProtocolEnabled #22686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
May 9, 2024
lhotari
reviewed
May 9, 2024
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/PulsarHandler.java
Show resolved
Hide resolved
shibd
approved these changes
May 9, 2024
|
/pulsarbot rerun-failure-checks |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2024
…Enabled (apache#22686) (cherry picked from commit d77c5de) (cherry picked from commit b178084)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…Enabled (apache#22686) (cherry picked from commit d77c5de) (cherry picked from commit b178084)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PulsarHandler.remoteAddressis the socket address of the Proxy when enabledhaProxyProtocolEnabled, we'd better print three addresses:local address,remote address,source remote addressin the log.Modifications
Print three addresses:
local address,remote address,source remote addressin the log.After this PR, the demo of addresses in the log is below:
Demo: [id: 0x2561bcd1, L:/10.0.136.103:6650! R:/240.240.0.5:58038] [SR:/240.240.0.5:58038]L: local AddressR: remote addressSR: source remote address. It is the source address when enabled "haProxyProtocolEnabled".Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x