Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [client] PIP-344 support feature flag supportsGetPartitionedMetadataWithoutAutoCreation #22773

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

poorbarcode
Copy link
Contributor

Motivation & Modifications

PIP-344 Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName)

Section Backward & Forward Compatibility

  • Old version client and New version Broker: The client will call the old API.

  • New version client and Old version Broker: The feature flag supports_binary_api_get_partitioned_meta_with_param_created_false will be false. The client will get a not-support error if the param createIfAutoCreationEnabled is false.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added this to the 3.4.0 milestone May 23, 2024
@poorbarcode poorbarcode self-assigned this May 23, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 23, 2024
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a minor comment.

@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@poorbarcode poorbarcode merged commit 6236116 into apache:master Jun 6, 2024
48 of 50 checks passed
poorbarcode added a commit that referenced this pull request Jun 19, 2024
…dMetadataWithoutAutoCreation (#22773)

(cherry picked from commit 6236116)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 24, 2024
…dMetadataWithoutAutoCreation (apache#22773)

(cherry picked from commit 6236116)
(cherry picked from commit 03c0975)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 24, 2024
…dMetadataWithoutAutoCreation (apache#22773)

(cherry picked from commit 6236116)
(cherry picked from commit 03c0975)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 24, 2024
…dMetadataWithoutAutoCreation (apache#22773)

(cherry picked from commit 6236116)
(cherry picked from commit 03c0975)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 25, 2024
…dMetadataWithoutAutoCreation (apache#22773)

(cherry picked from commit 6236116)
(cherry picked from commit 03c0975)
poorbarcode added a commit that referenced this pull request Jun 28, 2024
…dMetadataWithoutAutoCreation (#22773)

(cherry picked from commit 6236116)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
…dMetadataWithoutAutoCreation (apache#22773)

(cherry picked from commit 6236116)
(cherry picked from commit 03c0975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants