Add host name verification #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahmed-se
force-pushed
the
hostNameValidation1
branch
11 times, most recently
from
8e1a36c
to
fa723a7
Compare
aahmed-se
changed the title
rdhabalia
reviewed
Aug 31, 2018
| // certificate. | ||
| sock.set_verify_mode(ssl::verify_peer); | ||
| sock.set_verify_callback(ssl::rfc2818_verification(physicalAddress)); | ||
| sock.handshake(ssl_socket::client); |
There was a problem hiding this comment.
is it possible to add unit-test? we can reuse certificates used in java-test
There was a problem hiding this comment.
I will add unit test first I need to fix the build
aahmed-se
force-pushed
the
hostNameValidation1
branch
from
8f22bc6
to
2371fb2
Compare
aahmed-se
force-pushed
the
hostNameValidation1
branch
from
2371fb2
to
bf52dc6
Compare
aahmed-se
force-pushed
the
hostNameValidation1
branch
from
bf52dc6
to
284aa77
Compare
aahmed-se
changed the title
|
Added Tests |
aahmed-se
force-pushed
the
hostNameValidation1
branch
2 times, most recently
from
ff1ba4a
to
05afabc
Compare
aahmed-se
force-pushed
the
hostNameValidation1
branch
from
05afabc
to
c9dbfe2
Compare
aahmed-se
force-pushed
the
hostNameValidation1
branch
from
c9dbfe2
to
f222ab1
Compare
|
@merlimat @ivankelly please review it. |
aahmed-se
force-pushed
the
hostNameValidation1
branch
from
f222ab1
to
fd7fa17
Compare
ivankelly
approved these changes
Jan 28, 2019
|
@aahmed-se @merlimat hello, i am catching up the function for go client, want to know the progress of this pull request. |
|
@wolfstudy I need to rebase this on master but I consider it done for now. |
aahmed-se
force-pushed
the
hostNameValidation1
branch
6 times, most recently
from
ddbf5bf
to
53ce603
Compare
aahmed-se
force-pushed
the
hostNameValidation1
branch
from
53ce603
to
b91c777
Compare
ivankelly
added
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ssl host name verification as an optional client configuration for the C/C++ client library
This brings it to parity with the java client