Share EventLoopGroup between Broker and BK client #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
rdhabalia
approved these changes
Sep 18, 2018
| @@ -28,6 +30,6 @@ | |||
| * Provider of a new BookKeeper client instance | |||
| */ | |||
| public interface BookKeeperClientFactory { | |||
| BookKeeper create(ServiceConfiguration conf, ZooKeeper zkClient) throws IOException; | |||
| BookKeeper create(ServiceConfiguration conf, ZooKeeper zkClient, EventLoopGroup eventLoopGroup) throws IOException; | |||
There was a problem hiding this comment.
yes, this will help in avoiding context switching while publish and dispatching messages. however, do you see contention issue where high dispatching can impact publish?
|
Is this just about reducing the number of threads? I don't see how it would reduce context switches. |
|
@merlimat Please take a look at the comment. Is this PR need to onboard the 2.6.0 release? |
|
move to 2.7.0 |
|
move to 2.8.0 |
merlimat
force-pushed
the
share-io-threads
branch
from
807d895
to
b58e135
Compare
eolivelli
requested changes
May 19, 2021
...ar-broker/src/main/java/org/apache/pulsar/broker/service/schema/BookkeeperSchemaStorage.java
Show resolved
Hide resolved
BewareMyPower
pushed a commit
to streamnative/kop
that referenced
this pull request
May 26, 2021
### Motivation
When running KoP on Pulsar build by 2.8.0-rc-202105202205 or later, it will throw the following exception.
```
java.lang.NoSuchMethodError: org.apache.pulsar.broker.service.BrokerService.executor()Ljava/util/concurrent/ScheduledExecutorService;
at io.streamnative.pulsar.handlers.kop.KafkaTopicManager.<init>(KafkaTopicManager.java:87) ~[?:?]
at io.streamnative.pulsar.handlers.kop.KafkaRequestHandler.<init>(KafkaRequestHandler.java:246) ~[?:?]
at io.streamnative.pulsar.handlers.kop.KafkaChannelInitializer.initChannel(KafkaChannelInitializer.java:92) ~[?:?]
at io.streamnative.pulsar.handlers.kop.KafkaChannelInitializer.initChannel(KafkaChannelInitializer.java:34) ~[?:?]
at io.netty.channel.ChannelInitializer.initChannel(ChannelInitializer.java:129) [io.netty-netty-transport-4.1.63.Final.jar:4.1.63.Final]
at io.netty.channel.ChannelInitializer.handlerAdded(ChannelInitializer.java:112) [io.netty-netty-transport-4.1.63.Final.jar:4.1.63.Final]
at io.netty.channel.AbstractChannelHandlerContext.callHandlerAdded(AbstractChannelHandlerContext.java:938) [io.netty-netty-transport-4.1.63.Final.jar:4.1.63.Final]
at io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:609) [io.netty-netty-transport-4.1.63.Final.jar:4.1.63.Final]
at io.netty.channel.DefaultChannelPipeline.access$100(DefaultChannelPipeline.java:46) [io.netty-netty-transport-4.1.63.Final.jar:4.1.63.Final]
at io.netty.channel.DefaultChannelPipeline$PendingHandlerAddedTask.execute(DefaultChannelPipeline.java:1463) [io.netty-netty-transport-4.1.63.Final.jar:4.1.63.Final]
at io.netty.channel.DefaultChannelPipeline.callHandlerAddedForAllHandlers(DefaultChannelPipeline.java:1115) [io.netty-netty-transport-4.1.63.Final.jar:4.1.63.Final]
at io.netty.channel.DefaultChannelPipeline.invokeHandlerAddedIfNeeded(DefaultChannelPipeline.java:650) [io.netty-netty-transport-4.1.63.Final.jar:4.1.63.Final]
at io.netty.channel.AbstractChannel$AbstractUnsafe.register0(AbstractChannel.java:514) [io.netty-netty-transport-4.1.63.Final.jar:4.1.63.Final]
at io.netty.channel.AbstractChannel$AbstractUnsafe.access$200(AbstractChannel.java:429) [io.netty-netty-transport-4.1.63.Final.jar:4.1.63.Final]
at io.netty.channel.AbstractChannel$AbstractUnsafe$1.run(AbstractChannel.java:486) [io.netty-netty-transport-4.1.63.Final.jar:4.1.63.Final]
at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164) [io.netty-netty-common-4.1.63.Final.jar:4.1.63.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472) [io.netty-netty-common-4.1.63.Final.jar:4.1.63.Final]
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:384) [io.netty-netty-transport-native-epoll-4.1.63.Final.jar:4.1.63.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) [io.netty-netty-common-4.1.63.Final.jar:4.1.63.Final]
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) [io.netty-netty-common-4.1.63.Final.jar:4.1.63.Final]
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [io.netty-netty-common-4.1.63.Final.jar:4.1.63.Final]
```
It was cause by apache/pulsar#2603, which changed the brokerService.executor() interface from `ScheduledExecutorService` to `EventLoopGroup`.
### Modification
upgrade Pulsar dependency to 2.8.0-rc-202105251229 and resolve the exception.
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Share the Netty
EventLoopGroupthread pool between Pulsar broker and BookKeeper client.Since broker and bk client are running in same process, we can reduce the number of needed threads by having them sharing the same IO thread pool.