Simplify ServiceUrlProvider related APIs

[merlimat]

Motivation

I have seen few issues with ee5afa5:

1. There are 3 new methods in the PulsarClient interface which are meant to be used together. We should reduce
   the public API to the minimum possible. So I propose to just have a Pulsar.updateServiceUrl() which internally
   will perform all the needed operations in order to reconnect the client to new endpoint.

2. We shouldn't be exposing ClientConfigurationData in the API since it belongs to impl package

3. There is a leak of resources when the LookupService gets replaced with the new one since the existing
   is not closed.

Modifications

Refactored to simplify API for adding ServiceUrlProvider

cc/ @codelipenghui

It would be good to get this into 2.2 since it's changing the API for this new feature.

[codelipenghui]

👍 Matteo Merli <notifications@github.com> 于2018年9月28日周五 下午1:09写道：

…

Motivation I have seen few issues with ee5afa5 <ee5afa5> : 1. There are 3 new methods in the PulsarClient interface which are meant to be used together. We should reduce the public API to the minimum possible. So I propose to just have a Pulsar.updateServiceUrl() which internally will perform all the needed operations in order to reconnect the client to new endpoint. 2. We shouldn't be exposing ClientConfigurationData in the API since it belongs to impl package 3. There is a leak of resources when the LookupService gets replaced with the new one since the existing is not closed. Modifications Refactored to simplify API for adding ServiceUrlProvider cc/ @codelipenghui <https://github.com/codelipenghui> It would be good to get this into 2.2 since it's changing the API for this new feature. ------------------------------ You can view, comment on, or merge this pull request online at: #2671 Commit Summary - Simplify ServiceUrlProvider related APIs File Changes - *M* pulsar-broker/src/test/java/org/apache/pulsar/client/api/ServiceUrlProviderTest.java <https://github.com/apache/pulsar/pull/2671/files#diff-0> (8) - *M* pulsar-client/src/main/java/org/apache/pulsar/client/api/PulsarClient.java <https://github.com/apache/pulsar/pull/2671/files#diff-1> (35) - *M* pulsar-client/src/main/java/org/apache/pulsar/client/api/ServiceUrlProvider.java <https://github.com/apache/pulsar/pull/2671/files#diff-2> (25) - *M* pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java <https://github.com/apache/pulsar/pull/2671/files#diff-3> (8) - *M* pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java <https://github.com/apache/pulsar/pull/2671/files#diff-4> (2) - *M* pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java <https://github.com/apache/pulsar/pull/2671/files#diff-5> (20) - *M* pulsar-client/src/main/java/org/apache/pulsar/client/impl/HttpClient.java <https://github.com/apache/pulsar/pull/2671/files#diff-6> (18) - *M* pulsar-client/src/main/java/org/apache/pulsar/client/impl/HttpLookupService.java <https://github.com/apache/pulsar/pull/2671/files#diff-7> (5) - *M* pulsar-client/src/main/java/org/apache/pulsar/client/impl/LookupService.java <https://github.com/apache/pulsar/pull/2671/files#diff-8> (6) - *M* pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java <https://github.com/apache/pulsar/pull/2671/files#diff-9> (22) Patch Links: - https://github.com/apache/pulsar/pull/2671.patch - https://github.com/apache/pulsar/pull/2671.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2671>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMAkBRQbcliYeaS0MVCFlFW2b88gEQYXks5ufa8QgaJpZM4W93A0> .

[jiazhai]

rerun java8 tests

[merlimat]

run java8 tests