Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added stats for proxy operations and bytes #2740

Merged
merged 3 commits into from
Oct 18, 2018
Merged

Added stats for proxy operations and bytes #2740

merged 3 commits into from
Oct 18, 2018

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Oct 7, 2018

Motivation

Added 2 counters pulsar_proxy_ops and pulsar_proxy_bytes to expose the amount of traffic server by one Pulsar proxy instance.

@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Oct 7, 2018
@merlimat merlimat added this to the 2.3.0 milestone Oct 7, 2018
ivankelly
ivankelly reviewed Oct 8, 2018
View reviewed changes
Copy link
Contributor

@ivankelly ivankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for the binary protocol, so maybe the metric name should reflect that?

@merlimat
Copy link
Contributor Author

This is only for the binary protocol, so maybe the metric name should reflect that?

Good point. Will fix that.

Also I had plan to enable Jetty metrics in Prometheus so we'll have all stats available (in separate PR).

@merlimat
Copy link
Contributor Author

run integration tests

2 similar comments
@merlimat
Copy link
Contributor Author

run integration tests

@merlimat
Copy link
Contributor Author

run integration tests

@merlimat
Copy link
Contributor Author

run java8 tests

@merlimat merlimat merged commit 1fe6395 into apache:master Oct 18, 2018
@merlimat merlimat deleted the proxy-stats branch October 18, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivankelly ivankelly ivankelly left review comments

@sijie sijie sijie approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jai1 jai1 Awaiting requested review from jai1

@nkurihar nkurihar Awaiting requested review from nkurihar

Assignees
No one assigned
Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@merlimat @ivankelly @sijie