Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++] Fixed virtual destructors #2754

Merged
merged 1 commit into from
Oct 10, 2018
Merged

[c++] Fixed virtual destructors #2754

merged 1 commit into from
Oct 10, 2018

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Oct 9, 2018

Motivation

Few virtual destructors were missing and generating compile warnings.

@merlimat merlimat added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages component/c++ labels Oct 9, 2018
@merlimat merlimat added this to the 2.3.0 milestone Oct 9, 2018
@merlimat merlimat self-assigned this Oct 9, 2018
@merlimat merlimat merged commit 8d396c3 into apache:master Oct 10, 2018
@merlimat merlimat deleted the virtual-destructors branch October 10, 2018 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jai1 jai1 jai1 approved these changes

@sijie sijie Awaiting requested review from sijie

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@saandrews saandrews Awaiting requested review from saandrews

Assignees

@merlimat merlimat

Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@merlimat @jai1