Bump jetty to v9.4.12 #2811
Merged
Bump jetty to v9.4.12 #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent proxy changes (apache#2801) tickled some issues in jetty's 9.3 series, where clients can hang if running on machines with a lot of cores. This causes some tests to fail CI, while being impossible to repro locally (unless you have a 24 core machine lying around). Jetty reworked a lot of their selector code in 9.4, which appears to make the issue go away.
ivankelly
added
type/enhancement
|
Hmm, seems bumping the version isn't enough. Will look into the failures. |
Because 9.4 doesn't like it at all
|
rerun integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent proxy changes (#2801) tickled some issues in jetty's 9.3
series, where clients can hang if running on machines with a lot of
cores. This causes some tests to fail CI, while being impossible to
repro locally (unless you have a 24 core machine lying around).
Jetty reworked a lot of their selector code in 9.4, which appears to
make the issue go away.