change kafkaConnectSource to return KeyValue type record #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
requested changes
Nov 1, 2018
| public byte[] getValue() { | ||
| return valueConverter.fromConnectData( | ||
| public KeyValue<byte[], byte[]> getValue() { | ||
| byte[] keyBytes = keyConverter.fromConnectData( |
There was a problem hiding this comment.
line 157 would also convert the original key. I think we should try to cache keyBytes, so either getKey or getValue is called, the key is converted to keyBytes, any subsequent calls, will just use the cached bytes.
| public KeyValue<byte[], byte[]> getValue() { | ||
| byte[] keyBytes = keyConverter.fromConnectData( | ||
| srcRecord.topic(), srcRecord.keySchema(), srcRecord.key()); | ||
| byte[] valueBytes = valueConverter.fromConnectData( |
| String line1 = "This is the first line\n"; | ||
| os.write(line1.getBytes()); | ||
| os.flush(); | ||
| log.info("write 2 lines."); | ||
| kafkaConnectSource.getOffsetWriter().offset( |
There was a problem hiding this comment.
what is the reason of changing these lines here?
There was a problem hiding this comment.
Thanks @sijie , we already do the offset handling in KafkaConnecSource.
jiazhai
force-pushed
the
debe/connector_store_kv
branch
from
ab92694
to
d7aec0b
Compare
sijie
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change kafkaConnectSource to return KeyValue type record.