Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2984: Add producer flush method in cpp client #3020

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Issue #2984: Add producer flush method in cpp client #3020

merged 1 commit into from
Nov 20, 2018

Conversation

jiazhai
Copy link
Member

@jiazhai jiazhai commented Nov 20, 2018

Motivation

We already have flush() method in java api: http://pulsar.apache.org/api/client/org/apache/pulsar/client/api/Producer.html#flush--
It is better to provide a same method for cpp client.

Modifications

Add related methods in cpp client.
Add related tests.

Result

Cpp unit tests pass.

@jiazhai jiazhai self-assigned this Nov 20, 2018
@jiazhai jiazhai changed the title Issue #2894: Add producer flush method in cpp client Issue #2984: Add producer flush method in cpp client Nov 20, 2018
@jiazhai jiazhai mentioned this pull request Nov 20, 2018
Closed
merlimat
merlimat approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat added this to the 2.3.0 milestone Nov 20, 2018
@merlimat merlimat added type/feature The PR added a new feature or issue requested a new feature component/c++ labels Nov 20, 2018
@sijie sijie merged commit b982b5d into apache:master Nov 20, 2018
@merlimat merlimat mentioned this pull request Nov 20, 2018
Merged
jiazhai pushed a commit that referenced this pull request Nov 21, 2018
@merlimat @jiazhai
Fix C++ tests after merge (#3027)
fae43a9 
Motivation
There was a conflict between #3003 and #3020 that made C++ tests to fail after merging because of the namespaces changes.

* Fix C++ tests after merge
* Fix topic name comparison
* Increase tests timeout from 2 to 5min
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

@srkukarni srkukarni Awaiting requested review from srkukarni

Assignees

@jiazhai jiazhai

Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiazhai @merlimat @sijie