Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pulsar-Flink] Add Batch Json Sink Support #3046

Merged

Conversation

erenavsarogullari
Copy link
Member

Motivation

This PR aims to add Flink - Pulsar Batch Json Sink Support. If user works with Flink DataSet API and would like to write the DataSets to Pulsar in Json format, this sink can help.

Ref: Flink Batch Sink API

Modifications

Please find the change-set as follows:

1- Defines PulsarJsonOutputFormat to write Flink Batch DataSets into Pulsar by providing ready JsonSerializationSchema.
2- UT Coverages
3- FlinkPulsarBatchJsonSinkExample to show how to be used by users.
4- README.md documentation

@erenavsarogullari
Copy link
Member Author

rerun integration tests

2 similar comments
@erenavsarogullari
Copy link
Member Author

rerun integration tests

@erenavsarogullari
Copy link
Member Author

rerun integration tests

@sijie sijie added this to the 2.3.0 milestone Nov 23, 2018
@sijie
Copy link
Member

sijie commented Nov 23, 2018

run integration tests

1 similar comment
@erenavsarogullari
Copy link
Member Author

run integration tests

@erenavsarogullari
Copy link
Member Author

@sijie Thanks for review.
Integration tests failure looks irrelevant. However, it looks consistent failure.
org.apache.pulsar.tests.integration.offload.TestS3Offload.tiered-storage-test-suite

@jiazhai
Copy link
Member

jiazhai commented Nov 25, 2018

rerun integration tests

1 similar comment
@jiazhai
Copy link
Member

jiazhai commented Nov 25, 2018

rerun integration tests

@sijie sijie merged commit fe2c8ee into apache:master Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants