Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bookkeeperClientRegionawarePolicyEnabled and bookkeeperClientReor… #3171

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Add bookkeeperClientRegionawarePolicyEnabled and bookkeeperClientReor… #3171

merged 2 commits into from
Dec 13, 2018

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented Dec 12, 2018

…derReadSequenceEnabled config parameters

Fix #3119

Motivation

This allows to configure region-aware policy and read-reordering so that brokers first read on bookies of their own region.

Modifications

  • Added parameters:
# Enable region-aware bookie selection policy. BK will chose bookies from
# different regions and racks when forming a new bookie ensemble
# If enabled, the value of bookkeeperClientRackawarePolicyEnabled is ignored
bookkeeperClientRegionawarePolicyEnabled=false

# Enable/disable reordering read sequence on reading entries.
bookkeeperClientReorderReadSequenceEnabled=false
  • Fixed bug in ZkBookieRackAffinityMapping: the value set to racksWithHost by deserialize() was overriden by the affectation in setConf(). The fix just moves the hostname workaround in setConf().

Result

Users can enable bookkeeperClientRegionawarePolicyEnabled and bookkeeperClientReorderReadSequenceEnabled to make brokers read on bookies of their own region

@sijie sijie added type/feature The PR added a new feature or issue requested a new feature area/broker labels Dec 12, 2018
@sijie sijie added this to the 2.3.0 milestone Dec 12, 2018
@jiazhai jiazhai merged commit 24cc4bb into apache:master Dec 13, 2018
@cbornet cbornet deleted the region-aware-policy branch December 13, 2018 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Make brokers read on closest Bookie
3 participants