Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3290 Pulsar IO connector for Hbase sink #3368

Merged
merged 18 commits into from
Jan 31, 2019
Merged

Issue #3290 Pulsar IO connector for Hbase sink #3368

merged 18 commits into from
Jan 31, 2019

Conversation

ambition119
Copy link
Contributor

@ambition119 ambition119 commented Jan 14, 2019 •
edited
Loading

Supporting the ability to write data to HBase sink #3290

@srkukarni
Copy link
Contributor

rerun java tests

@ambition119
Copy link
Contributor Author

ambition119 commented Jan 15, 2019 •
edited by jiazhai
Loading

run Integration Tests

error:
org.apache.pulsar.tests.integration.functions.PulsarFunctionsThreadTest.pulsar-test-suite

@jiazhai
Copy link
Member

jiazhai commented Jan 15, 2019

run Integration Tests

@jiazhai jiazhai requested a review from sijie January 16, 2019 01:53
sijie
sijie requested changes Jan 17, 2019
View reviewed changes
Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a documentation page? also if it is possible, it would be great to add an integration test.

pulsar-io/hbase/pom.xml Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseSinkConfig.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseGenericRecordSink.java Show resolved Hide resolved
sijie
sijie requested changes Jan 21, 2019
View reviewed changes
pulsar-io/hbase/pom.xml Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
@sijie
Copy link
Member

sijie commented Jan 21, 2019

@ambition119 did you push new changes? I saw you resolved the review conversations without pushing new changes. I am guessing you made local changes but didn't push to remote.

@ambition119
Copy link
Contributor Author

@ambition119 did you push new changes? I saw you resolved the review conversations without pushing new changes. I am guessing you made local changes but didn't push to remote.

sorry, I forgot to submit the code.

@ambition119
Copy link
Contributor Author

ambition119 commented Jan 23, 2019 •
edited
Loading

run cpp Tests

for error:
Pulsar SQL :: Pulsar Presto Distribution ........... FAILURE [ 17.395 s]

run Integration Tests

for error:
org.apache.pulsar.tests.integration.functions.PulsarFunctionsThreadTest.pulsar-test-suite

@ambition119
Copy link
Contributor Author

run Integration Tests

Pulsar SQL :: Pulsar Presto Distribution ........... FAILURE [ 18.556 s]

@ambition119
Copy link
Contributor Author

run Integration Tests

org.testcontainers.containers.ContainerLaunchException: Container startup failed

sijie
sijie requested changes Jan 28, 2019
View reviewed changes
Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ambition119 can you create a github issue for adding an integration test for hbase connectors?

pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Show resolved Hide resolved
pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java Outdated Show resolved Hide resolved
@jiazhai
Copy link
Member

jiazhai commented Jan 29, 2019

run java8 tests

@ambition119
Copy link
Contributor Author

ambition119 commented Jan 29, 2019 •
edited
Loading

@ambition119 can you create a github issue for adding an integration test for hbase connectors?

hbase integration test code also ok, then create new PR and review.
image

@ambition119
Copy link
Contributor Author

run java8 Tests

@sijie sijie added this to the 2.3.0 milestone Jan 31, 2019
@sijie
Copy link
Member

sijie commented Jan 31, 2019

Well done! @ambition119

@sijie sijie merged commit 9871200 into apache:master Jan 31, 2019
@dlg99 dlg99 mentioned this pull request Feb 23, 2022
Open
@sijie sijie mentioned this pull request Feb 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

@srkukarni srkukarni Awaiting requested review from srkukarni

Assignees

@ambition119 ambition119

Labels
area/connector
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ambition119 @srkukarni @jiazhai @sijie