Added suppport for Kafka partitioner and explicit setting of partition on record #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Jan 28, 2019
jerrypeng
approved these changes
Jan 28, 2019
|
run integration tests |
|
retest this please |
ivankelly
requested changes
Jan 31, 2019
site2/docs/adaptors-kafka.md
Outdated
| @@ -129,7 +129,7 @@ Properties: | |||
| | Config property | Supported | Notes | | |||
| |:----------------------------------------|:----------|:------------------------------------------------------------------------------| | |||
| | `acks` | Ignored | Durability and quorum writes are configured at the namespace level | | |||
| | `auto.offset.reset` | Yes | Will have a default value of 'latest' if user does not give specific setting. | | |||
| | `auto.offset.reset` | Yes | Will have a default value of `latest` if user does not give specific setting. | | |||
There was a problem hiding this comment.
Added superfluous whitespace.
There was a problem hiding this comment.
I just fixed the .. and aligned the columns in the source md text structure.
There was a problem hiding this comment.
...pulsar-client-kafka/src/main/java/org/apache/kafka/clients/producer/PulsarKafkaProducer.java
Outdated
Show resolved
Hide resolved
...client-test/src/test/java/org/apache/pulsar/tests/integration/compat/kafka/KafkaApiTest.java
Outdated
Show resolved
Hide resolved
|
@ivankelly PTAL again |
ivankelly
reviewed
Feb 1, 2019
| @@ -18,6 +18,7 @@ | |||
| */ | |||
| package org.apache.kafka.clients.producer; | |||
|
|
|||
| import java.nio.charset.Charset; | |||
There was a problem hiding this comment.
import static java.nio.charset.StandardCharsets.UTF_8;
site2/docs/adaptors-kafka.md
Outdated
| @@ -129,7 +129,7 @@ Properties: | |||
| | Config property | Supported | Notes | | |||
| |:----------------------------------------|:----------|:------------------------------------------------------------------------------| | |||
| | `acks` | Ignored | Durability and quorum writes are configured at the namespace level | | |||
| | `auto.offset.reset` | Yes | Will have a default value of 'latest' if user does not give specific setting. | | |||
| | `auto.offset.reset` | Yes | Will have a default value of `latest` if user does not give specific setting. | | |||
There was a problem hiding this comment.
ivankelly
approved these changes
Feb 1, 2019
|
retest this please |
|
run cpp tests |
|
run integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
partitioner.classwith a custom partitioner