Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In functions log topic appender, don't set producer name #3544

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Feb 7, 2019

Motivation

When enabling log topic in functions, we shouldn't set the producer name, otherwise multiple function instances will fail to produce on the log topic.

At the same time:

  • Increase batch time to have more batching (since the latency hit will not be important here)
  • Enabled LZ4 compression, since it's always good for logs.

@merlimat merlimat added type/bug The PR fixed a bug or issue reported a bug area/function labels Feb 7, 2019
@merlimat merlimat added this to the 2.3.0 milestone Feb 7, 2019
@merlimat merlimat self-assigned this Feb 7, 2019
@merlimat
Copy link
Contributor Author

merlimat commented Feb 8, 2019

run integration tests

@merlimat merlimat merged commit c40bb08 into apache:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants