Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go client] add validation host name for ClientOptions #3580

Merged
merged 3 commits into from
Feb 13, 2019
Merged

[go client] add validation host name for ClientOptions #3580

merged 3 commits into from
Feb 13, 2019

Conversation

wolfstudy
Copy link
Member

Motivation

[go client] add validation host name for ClientOptions

@wolfstudy
[go client] add validation hostName for ClientOptions
069d96c 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
[go client] add validation hostName for ClientOptions
d0918ca 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
rename ValidationHostName to TLSValidateHostname
10486ad 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
Copy link
Member Author

@merlimat PTAL again, thanks

@wolfstudy
Copy link
Member Author

run cpp tests
run java8 tests

merlimat
merlimat approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat merged commit 5ca75ef into apache:master Feb 13, 2019
@merlimat merlimat added type/feature The PR added a new feature or issue requested a new feature component/go labels Feb 13, 2019
@merlimat merlimat added this to the 2.3.0 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees
No one assigned
Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wolfstudy @merlimat