[pulsar-broker] auto refresh new tls certs for jetty webserver #3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Feb 22, 2019
| @@ -240,6 +240,9 @@ authenticateOriginalAuthData=false | |||
| # Deprecated - Use webServicePortTls and brokerServicePortTls instead | |||
| tlsEnabled=false | |||
|
|
|||
| # Tls cert refresh duration in seconds (set 0 to check on every new connection) | |||
| tlsCertRefreshCheckDurationSec=300 | |||
There was a problem hiding this comment.
Don't we already have a refresh time from #3568?
There was a problem hiding this comment.
yes, it's the same but I have renamed with tls prefix and we also missed to define it into all conf files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, broker starts webservice on jetty in tls mode but jetty doesn't have capabilities to refresh the tls certs if certs have been rotated. So, added capability to refresh certs for tls-webservice.
Modification
Note: