In Java allow messages that compress to <5mb to be sent with batching enabled #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
approved these changes
Feb 28, 2019
|
run integration tests |
1 similar comment
|
run integration tests |
jerrypeng
approved these changes
Mar 1, 2019
|
run java8 tests |
1 similar comment
|
run java8 tests |
|
run java8 tests |
2 similar comments
|
run java8 tests |
|
run java8 tests |
sijie
approved these changes
Mar 4, 2019
|
run java8 tests |
|
run java8 tests |
… testing in ProducerConsumerTest
|
run java8 tests |
jiazhai
approved these changes
Mar 14, 2019
merlimat
added a commit
that referenced
this pull request
Mar 29, 2019
… enabled (#3718) * In Java allow messages that compress to <5mb to be sent with batching enabled * Test is not anymore accurate since behavior changed and we're already testing in ProducerConsumerTest
|
Merged in 2.3.1 at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similarly to what done in #3673, apply the same behavior with or without batching when publishing messages >5MB that can be compressed to fit into the threshold.