Use at least 8 threads in Jetty thread pool #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrypeng
approved these changes
Mar 7, 2019
|
rerun java8 tests |
|
rerun java8 tests |
1 similar comment
|
rerun java8 tests |
sijie
approved these changes
Mar 7, 2019
merlimat
added a commit
that referenced
this pull request
Mar 29, 2019
### Motivation Use at least 8 threads to avoid having Jetty go into threads starving and having the possibility of getting into a deadlock where a Jetty thread is waiting for another HTTP call to complete in same thread. This solve the issues of requests timing out when the broker is making REST calls to itself. Such examples are when running in standalone mode and creating a function.
|
Merged in 2.3.1 at |
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
May 26, 2019
fixes apache#4359 same as apache#3776 Use at least 8 threads to avoid having Jetty go into threads starving and having the possibility of getting into a deadlock where a Jetty thread is waiting for another HTTP call to complete in same thread.
|
@vicaya That is already configurable. The only question was always what was the most conservative default value. |
This was referenced Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use at least 8 threads to avoid having Jetty go into threads starving and
having the possibility of getting into a deadlock where a Jetty thread is
waiting for another HTTP call to complete in same thread.
This solve the issues of requests timing out when the broker is making REST
calls to itself. Such examples are when running in standalone mode and
creating a function.