Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kafka's ProducerConfig.REQUEST_TIMEOUT_MS_CONFIG. #3797

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

MarvinCai
Copy link
Contributor

@MarvinCai MarvinCai commented Mar 10, 2019

Motivatio
Support Kafka's ProducerConfig.REQUEST_TIMEOUT_MS_CONFIG #1090

Previously ProducerBuilder.sendTimeout was set by parsing Kafka's ProducerConfig.MAX_BLOCK_MS_CONFIG.
According to Kafka's document it's for

Controlling how long KafkaProducer.send() and KafkaProducer.partitionsFor() will block either because the buffer is full or metadata unavailable.

But ProducerBuilder.sendTimeout is for

If a message is not acknowledged by the server before the sendTimeout expires, an error will be reported.

And Kafka's ProducerConfig.REQUEST_TIMEOUT_MS_CONFIG, according to the document is for:

Controlling the maximum amount of time the client will wait for the response of a request.

Which I think would be better fit purpose of Pulsar's ProducerBuilder.sendTimeout.

@MarvinCai MarvinCai changed the title Support kafka timeout Support Kafka's ProducerConfig.REQUEST_TIMEOUT_MS_CONFIG. Mar 10, 2019
@sijie sijie assigned sijie and MarvinCai and unassigned sijie Mar 11, 2019
@sijie sijie added area/client component/kafka type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Mar 11, 2019
@sijie sijie added this to the 2.4.0 milestone Mar 11, 2019
@sijie
Copy link
Member

sijie commented Mar 11, 2019

@MarvinCai

Nice catch!

@sijie
Copy link
Member

sijie commented Mar 11, 2019

run integration tests
run java8 tests

@sijie
Copy link
Member

sijie commented Mar 11, 2019

run java8 tests

@sijie sijie merged commit 117321d into apache:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants