Prevent message-replay of already acknowledged messages #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
rdhabalia
force-pushed
the
replay
branch
4 times, most recently
from
f53d660
to
d8d2499
Compare
merlimat
approved these changes
Sep 26, 2016
sboobna
reviewed
Sep 26, 2016
| // filters out messages which are already acknowledged | ||
| Set<Position> alreadyAcknowledgedPositions = Sets.newHashSet(); | ||
| positions.stream().filter(position -> { | ||
| return individualDeletedMessages.contains((PositionImpl) position) |
There was a problem hiding this comment.
any access to the individualDeletedMessages should be from within a r/w lock
There was a problem hiding this comment.
yes.. i created PR to fix it.
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
added node-pre-gyp support
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
Fix CI the openjdk-8-jre-headless can't download
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In Race condition of: (1) message-redelivery-request and (2) ack-message: broker tries to replay already acked messages which results into invalid entry while replaying it and it keeps retrying reading of same entry.
Right now, It happens only when consumer has already consumed all publish messages and broker receives redelivery of unack message request.
Modifications
Result
Broker will ignore already acked message while replaying it.