Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix message_id_serialize to empty slice #3801

Merged
merged 2 commits into from Mar 14, 2019
Merged

fix message_id_serialize to empty slice #3801

merged 2 commits into from Mar 14, 2019

Conversation

Tevic
Copy link
Contributor

@Tevic Tevic commented Mar 12, 2019 •
edited

@Tevic Tevic mentioned this pull request Mar 12, 2019
Closed
sijie
sijie reviewed Mar 12, 2019
View reviewed changes
Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tevic is it possible to add a simple unit test for this?

@Tevic
Copy link
Contributor Author

Tevic commented Mar 12, 2019

@Tevic is it possible to add a simple unit test for this?

Sure, i'm not familiar with c++ so i just add the golang test.

merlimat
merlimat approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat added this to the 2.3.1 milestone Mar 13, 2019
@merlimat merlimat added type/bug The PR fixed a bug or issue reported a bug component/go labels Mar 13, 2019
@merlimat
Copy link
Contributor

run java8 tests

2 similar comments
@merlimat
Copy link
Contributor

run java8 tests

@jiazhai
Copy link
Member

jiazhai commented Mar 14, 2019

run java8 tests

@merlimat merlimat merged commit 9bd4f49 into apache:master Mar 14, 2019
merlimat pushed a commit that referenced this pull request Mar 29, 2019
@Tevic @merlimat
fix message_id_serialize to empty slice (#3801)
d131a2b 
* fix message_id_serialize to empty slice

* test for serialize and deserialize
@merlimat
Copy link
Contributor

merlimat commented Apr 1, 2019

Merged in 2.3.1 at
d131a2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie left review comments

@merlimat merlimat merlimat approved these changes

@jiazhai jiazhai jiazhai approved these changes

Assignees
No one assigned
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tevic @merlimat @jiazhai @sijie